Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation face recognition #28

Merged
merged 1 commit into from
May 14, 2024
Merged

Visualisation face recognition #28

merged 1 commit into from
May 14, 2024

Conversation

GlennDeLoose01
Copy link
Contributor

Added visualisation using OpenCV imshow, that shows bounding boxes on video-frame.

@GlennDeLoose01 GlennDeLoose01 added the enhancement New feature or request label May 14, 2024
@GlennDeLoose01 GlennDeLoose01 self-assigned this May 14, 2024
Copy link
Member

@cedricve cedricve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, still some questions

@@ -93,8 +92,6 @@ def process_frame(cap, video_char, qdrant, verbose=True, show_frame=False):
cv2.putText(frame, name, (x, y-40), cv2.FONT_HERSHEY_SIMPLEX, 0.9, (36,255,12), 2)
cv2.putText(frame, str(score), (x, y-10), cv2.FONT_HERSHEY_SIMPLEX, 0.9, (36,255,12), 2)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you are cleaning up @GlennDeLoose01 ;)

@@ -1,6 +1,5 @@
from utils.QueueProcessor import QueueProcessor
from utils.FacialRecognition import FacialRecognition
from deepface import DeepFace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove this?

@cedricve cedricve merged commit 43bbc6c into main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants