generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: TSP (tlm space packet) Ver.2 の仕様を追加 #551
Draft
meltingrabbit
wants to merge
3
commits into
develop
Choose a base branch
from
feature/tsp_v2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
documentation
Improvements or additions to documentation
priority::high
priorityg high
labels
Apr 17, 2023
meltingrabbit
commented
Apr 18, 2023
Comment on lines
+118
to
+125
#### バージョンの使い分け | ||
- Version 1 | ||
- 主に,Telemetry ID で区別される,パケットごとに構造化され定義されたテレメトリ (Character Tlm Packet) に使う | ||
- C2A では,Tlm Cmd DB の Tlm DB によってスキーマが定義され,時系列データベースなどに格納されることが一般的である | ||
- 基本的にはパケット分割されない(Sequence Flag が Standalone Packet である) | ||
- Version 2 | ||
- 主に,画像などのミッションデータやメモリダンプ (Binary Tlm Packet) を送信するときに使う | ||
- パケット分割は許容される |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meltingrabbit
commented
Apr 18, 2023
Comment on lines
+112
to
+116
##### Version 2 | ||
- On-Board Subnetwork Time (将来拡張) | ||
- 各ボードで作られたパケットの時刻を統一的に管理するために,オンボードサブネットワークで共通の時刻体系に基づくテレメトリ生成時刻 | ||
- `0xFFFFFFFF` の場合, パケット中継中に MOBC (地上局とつながる OBC) で,上書き設定される | ||
- On-Board Subnetwork Time を取得できない機器向け |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここもきになる
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
つまり,
- ver1, ver2 で offset が異なってしまっても良いのか
- そもそもこれ必要か?
meltingrabbit
changed the title
TSP (tlm space packet) Ver.2 の仕様を追加
WIP: TSP (tlm space packet) Ver.2 の仕様を追加
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
TSP (tlm space packet) Ver.2 の仕様を追加
Issue
NA
詳細
ミッションデータをDLするときのパケット仕様を追加
検証結果
NA
補足
これまでのパケット(tlm db で定義される,構造化されたテレメ)と,ミッションデータのテレメ,それぞれを区別する名前がほしい....
前者を Character tlm packet,後者を Binary tlm packet,とか? @sksat @KOBA789 @ToshiAki64 @chutaro どう思います?