CTCPをCCPとTCPに分離 #209
Merged
CTCPをCCPとTCPに分離 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
documentation
sksat
reviewed
Jan 24, 2022
meltingrabbit
force-pushed
the
feature/divide_ctcp_to_ccp_and_ctp
branch
from
ba65db7 to
247a7c6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
meltingrabbit
force-pushed
the
feature/divide_ctcp_to_ccp_and_ctp
branch
from
17ae660 to
162f425
Compare
yngyu
reviewed
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CTCPをCCPとTCPに分離
Issue
詳細
CTCPをCommonTlmCmdPacket,CommonTlmPacket,CommonCmdPacketに分離したTCPだが，それは今後直す検証結果
既存のCIがすべて通ればOK
影響範囲
ここでは限定的．次に続くPRで大きな影響が出てくる見込み
補足
CTCPは 適当にCommonTlmCmdPacket,CommonTlmPacket,CommonCmdPacketになおした．今後，これらが別の実体を指すようになった場合，ここで不適切だった修正でビルドエラーが出るはずなので，そのときに直すCTCPを適切に割り振るのは 一時的なCTCPのtypedefを消し，各所のCTCPをCommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacketのどれかに割り当てる #210 でやる．typedef CTCP CommonTlmCmdPacketしてしまう．