[WIP] Add Sagitta Version Telemetry #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conjikidow
added
✈️ priority::medium
conjikidow
requested review from
200km,
seki-hiro,
suzuki-toshihir0 and
t-hosonuma
and removed request for
a team
conjikidow
commented
May 18, 2024
| @@ -113,7 +113,7 @@ typedef enum | |||
| // others 全体のテレメとかを登録 | |||
| // システム試験TLM: | |||
|
|
|||
| // BCT MAX : 80 | |||
| // BCT MAX : 90 | |||
There was a problem hiding this comment.
#295 の際に更新されていなかった分が反映されたため，本PRとは直接関係ない。
conjikidow
commented
May 19, 2024
| .# ===== POWER TELEMETRY ===== | ||
| AOBC_RT.DI_SAGITTA_CHANGE_PARAMETER 18 0 11 | ||
| wait_sec 1 | ||
| AOBC_RT.DI_SAGITTA_SET_PARAMETER 18 | ||
| wait_sec 1 | ||
| AOBC_RT.TG_GENERATE_RT_TLM 0x43 # AOBC_SAGITTA4 |
There was a problem hiding this comment.
#137 でテレメのダウンリンクが抜けていたため，本PRで追加した。以降も同様。
|
@conjikidow これどうしようか？マージして、subscriptionで下せるかのメーカー確認をissue登録する？ |
|
現状下ろせていないこと，下ろせないのであれば今mergeする必要もないことから，確認して下ろせるようになってからで良いかなと思っています。 |
|
OKです、issue登録だけしておきました。 |
|
ありがとうございます。 |
conjikidow
changed the title
conjikidow
force-pushed
the
feature/add-sagitta-ver-tlm
branch
from
c87eea4 to
841cadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
詳細
Sagitta の Version テレメトリを AOBC_SAGITTA1 に追加した。
検証結果
ビルドチェック (どちらもチェック)
動作確認チェック (いずれかをチェック)
試験結果詳細記述場所 or 詳細ログ保存場所へのリンク
補足
NA