SS/STTのDS initをコマンド化しEHを更新 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michinarikake
requested review from
200km,
seki-hiro,
suzuki-toshihir0,
t-hosonuma and
conjikidow
and removed request for
a team
200km
added
🐳 major update
|
SILSで以下を確認
|
seki-hiro
reviewed
May 17, 2024
| { | ||
| (void)packet; | ||
| uint8_t i; | ||
| uint8_t is_ok; |
There was a problem hiding this comment.
[MUST]初期化をお願いします。
Suggested change
| uint8_t is_ok; | |
| uint8_t is_ok = 0; |
There was a problem hiding this comment.
is_ok |=をis_ok &=にして初期化はis_ok = 1にしようと思います
| { | ||
| (void)packet; | ||
| uint8_t i; | ||
| uint8_t is_ok; |
There was a problem hiding this comment.
[MUST]初期化をお願いします。
Suggested change
| uint8_t is_ok; | |
| uint8_t is_ok = 0; |
michinarikake
commented
May 17, 2024
| for (i = 0; i < NANOSSOC_D60_PARAMETERS_NUMBER_OF_MOUNTED_SENSOR; ++i) | ||
| { | ||
| ret = NANOSSOC_D60_DS_init(&nanossoc_d60_driver_[i], &DI_NANOSSOC_D60_rx_buffer_[i]); | ||
| is_ok |= (ret == DS_INIT_OK); |
| ret = DS_init_stream_rec_buffer(&DI_NANOSSOC_D60_rx_buffer_[i], | ||
| DI_NANOSSOC_D60_rx_buffer_allocation_[i], | ||
| sizeof(DI_NANOSSOC_D60_rx_buffer_allocation_[i])); | ||
| is_ok |= (ret == DS_ERR_CODE_OK); |
|
@michinarikake 修正ありがとう。マージできる状態ということでOKよね？ |
|
はい、マージできます！よろしくお願いします！ |
src/src_user/TlmCmd/NormalBlockCommandDefinition/nbc_nanossoc_d60.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Toshihiro Suzuki <[email protected]>
|
すみません、ミスってました... |
seki-hiro
approved these changes
May 20, 2024
|
最新devをとりこんでvMicro build通ったのでマージします。 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
詳細
SS, STTのテレメエラーの対策としてDS_initとDS_init_stream_rec_bufferをラップしたコマンドを定義した。
また, EHのSS, STTのreset BCにこれらのコマンドを追加した
検証結果
ビルドチェック (どちらもチェック)
動作確認チェック (いずれかをチェック)
試験結果詳細記述場所 or 詳細ログ保存場所へのリンク
補足
何かあれば書く。なければ
NAとする。