Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug PIC INA read error #253

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix bug PIC INA read error #253

merged 1 commit into from
Oct 31, 2023

Conversation

SeirenTDoi
Copy link
Collaborator

@SeirenTDoi SeirenTDoi commented Oct 31, 2023 •
edited by 200km
Loading

Issue

#252

詳細

本来のINA260初期化コマンドの直前にダミーとして1つ初期化コマンドを挿入する。
これにより本来のINA260初期化コマンドは成功するようになる。

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果

NG事象が再現する2枚の基板共、本対策で再現しなくなった。

補足

NA

@SeirenTDoi SeirenTDoi added 🐛 bug Something isn't working ✈️ priority::medium priority medium 🐟 patch Patch Update labels Oct 31, 2023
@SeirenTDoi SeirenTDoi self-assigned this Oct 31, 2023
@SeirenTDoi SeirenTDoi requested review from sksat and a team as code owners October 31, 2023 00:13
@SeirenTDoi SeirenTDoi requested review from 200km, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team October 31, 2023 00:13
@SeirenTDoi SeirenTDoi merged commit 94a5afc into develop Oct 31, 2023
15 of 17 checks passed
@SeirenTDoi SeirenTDoi deleted the feature/fix_bug_ina branch October 31, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@200km 200km 200km approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@suzuki-toshihir0 suzuki-toshihir0 Awaiting requested review from suzuki-toshihir0 suzuki-toshihir0 is a code owner automatically assigned from ut-issl/aocs

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma t-hosonuma is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@SeirenTDoi SeirenTDoi

Labels
✈️ priority::medium priority medium 🐛 bug Something isn't working 🐟 patch Patch Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeirenTDoi @200km