Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPSR_RANGE_OBSERVEモードの削除 #248

Merged
merged 4 commits into from
Feb 1, 2024
Merged

GPSR_RANGE_OBSERVEモードの削除 #248

merged 4 commits into from
Feb 1, 2024

Conversation

t-hosonuma
Copy link
Contributor

@t-hosonuma t-hosonuma commented Oct 20, 2023 •
edited
Loading

Issue

詳細

GPSR_RANGE_OBSERVEモードをモードリストから削除

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果詳細記述場所 or 詳細ログ保存場所へのリンク

  • TBD

補足

NA

@t-hosonuma t-hosonuma added ✈️ priority::medium priority medium 🐳 major update Major update 🛰️ C2A Command Centric Architecture labels Oct 20, 2023
@t-hosonuma t-hosonuma requested a review from 200km October 20, 2023 12:31
@t-hosonuma t-hosonuma self-assigned this Oct 20, 2023
@t-hosonuma t-hosonuma requested review from sksat and a team as code owners October 20, 2023 12:31
@t-hosonuma t-hosonuma requested review from suzuki-toshihir0 and conjikidow and removed request for a team October 20, 2023 12:31
@200km 200km added this to the v9.0.0 Major Update milestone Jan 18, 2024
200km
200km approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないです。

@200km 200km linked an issue Jan 29, 2024 that may be closed by this pull request
MD_MODEID_GPSR_RANGE_OBSERVE モードの必要性確認 #157
Closed
@t-hosonuma t-hosonuma changed the title WIP:GPSR_RANGE_OBSERVEモードの削除 GPSR_RANGE_OBSERVEモードの削除 Feb 1, 2024
@t-hosonuma
Copy link
Contributor Author

Approve頂いた＆V-microビルドが通ったのでマージします

@t-hosonuma t-hosonuma merged commit 1048a7a into develop Feb 1, 2024
9 of 11 checks passed
@t-hosonuma t-hosonuma deleted the feature/remove_range_observe_mode branch February 1, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@200km 200km 200km approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@suzuki-toshihir0 suzuki-toshihir0 Awaiting requested review from suzuki-toshihir0 suzuki-toshihir0 is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@t-hosonuma t-hosonuma

Labels
✈️ priority::medium priority medium 🛰️ C2A Command Centric Architecture 🐳 major update Major update
Projects
None yet
Milestone
v9.0.0 Major Update
Development

Successfully merging this pull request may close these issues.

MD_MODEID_GPSR_RANGE_OBSERVE モードの必要性確認
2 participants
@t-hosonuma @200km