Escape character default bug #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a '\' was encountered followed by a character that has no special meaning, the character was added as an integer. For instance: '\$' was turned into the string '36' instead of the string '$'.
DavyLandman
reviewed
Jun 18, 2024
src/test/java/io/usethesource/vallang/io/StandardTextReaderTest.java
Outdated
Show resolved
Hide resolved
|
Nice catch @PieterOlivier 👍 ; Saved is all from a long debugging session |
well, Pieter was already stuck in stuck in such a session ;) |
The test failed to generate the expected StackOverflowError, so with this commit I try to force the error again.
|
Thanks @PieterOlivier for also fixing the test that was unrelated to your specific fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
\was encountered followed by a character that has no special meaning, the character was added as an integer.For instance:
\$was turned into the string'36'instead of the string'$'.