Solve perf issue serializing large collections #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
force-pushed
the
faster-serialize-large-collections
branch
from
be73eff to
ab905ed
Compare
DavyLandman
force-pushed
the
faster-serialize-large-collections
branch
from
ab905ed to
d1102a2
Compare
We have a stackless structured visitor that doesn't require large call stacks to deal with deeply nested ASTs. While this worked great for deep ASTs, it doesn't work great for big flat collections (aka wide). Big collections would require the same amount of memory, just to prepare the stack with all the entries. Now we have iterating entries on the stack, that can be "returned to" multiple times.
DavyLandman
force-pushed
the
faster-serialize-large-collections
branch
from
d1102a2 to
3876e84
Compare
|
Ok nice. I was halfway something very similar; you beat me to it |
|
looks great |
|
thanks, the solution came to me the middle of brushing my teeth, then it took 30min to implement it. I'll add synthetic benchmark results soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a stackless structured visitor that doesn't require large call stacks to deal with deeply nested ASTs.
While this worked great for deep ASTs, it doesn't work great for big flat collections (aka wide).
Big collections would require the same amount of memory, just to prepare the stack with all the entries. Now we have iterating entries on the stack, that can be "returned to" multiple times.
Note, I had to change the tests, as they assumed reverse orders for sets & maps in the visitor, which was not an actual requirement.