Fixed the maven-shade-plugin configuration #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
=======================================
- Coverage 49% 49% -1%
+ Complexity 6335 6318 -17
=======================================
Files 666 666
Lines 59687 59687
Branches 8670 8670
=======================================
- Hits 29619 29602 -17
- Misses 27830 27849 +19
+ Partials 2238 2236 -2 ☔ View full report in Codecov by Sentry. |
|
Great! Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PaulKlint noticed that the Rascal jar was broken after the recent merge of the Maven branch, in which the configuration of the
maven-shade-pluginwas updated. It turns out that the plugin was configured incorrectly, which is fixed in this PR.