-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New functions for checking multiple sets #1925
Open
linuswagner
wants to merge
5
commits into
usethesource:main
Choose a base branch
from
linuswagner:setfn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -157,6 +157,51 @@ test bool testDynamicTypes2() {set[value] s = {"1",2,3}; return set[int] _ := s | |
test bool testDynamicTypes3() {set[value] s = {"1",2,3}; return set[int] _ := s & {2,3};} | ||
test bool testDynamicTypes4() = {"1", *int _} := {"1",2,3}; | ||
|
||
|
||
|
||
|
||
// intersection | ||
test bool testIntersectionEmptySet() { | ||
try { | ||
intersection({}); | ||
} | ||
catch IllegalArgument(wholeSet, msg): { | ||
return wholeSet == {} && msg == "Intersection only possible with at least two sets."; | ||
} | ||
return false; | ||
} | ||
|
||
test bool testIntersectionSingleElement() { | ||
try { | ||
intersection({{1}}); | ||
} | ||
catch IllegalArgument(wholeSet, msg): { | ||
return wholeSet == {{1}} && msg == "Intersection only possible with at least two sets."; | ||
} | ||
return false; | ||
} | ||
|
||
test bool testIntersectionNoOverlap() {return intersection({{1,2}, {3,4}}) == {};} | ||
test bool testIntersectionOverlap() {return intersection({{1,2}, {2,3}, {2,5}}) == {2};} | ||
|
||
// isDisjoint | ||
test bool testIsPairwiseDisjointEmpty() { | ||
try { | ||
isPairwiseDisjoint([]); | ||
} | ||
catch IllegalArgument(wholeInput, msg): { | ||
return wholeInput == [] && msg == "Only two or more sets can be pairwise disjoint."; | ||
} | ||
return false; | ||
} | ||
|
||
test bool testIsPairwiseDisjointSingleElement() { | ||
try { | ||
isPairwiseDisjoint([{1}]); | ||
} | ||
catch IllegalArgument(wholeInput, msg): { | ||
return wholeInput == [{1}] && msg == "Only two or more sets can be pairwise disjoint."; | ||
} | ||
return false; | ||
} | ||
|
||
test bool testIsPairwiseDisjointIdenticalElements() {return isPairwiseDisjoint([{1}, {1}]) == false;} | ||
test bool testIsPairwiseDisjointNoOverlap() {return isPairwiseDisjoint([{1,2},{3,4},{5,6}]) == true;} | ||
test bool testIsPairwiseDisjointOverlap() {return isPairwiseDisjoint([{1,2}, {-4,5}, {1,6,7}]) == false;} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if possible, think of an way to write an random tests. something like: test bool testRandomPairwiseDisjoint(set[value] a, set[value] b) = (a & b == {}) == isPairwiseDisjoint([a,b]); or even better if you could do it without using the intersection operator. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sets
==wholeInput
, no need to give it two names right?