Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat configs: don't duplicate dbconnection in config_vars, pass it through env #37

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

LeoSabantsev
Copy link
Contributor

Add feature from my pg_service_template PR

Attempt to fix problem with port mapping in docker-compose in Makefile (in original version service in unavailable when call it from local grpc stub)

@LeoSabantsev LeoSabantsev changed the title [FEAT] avoid usused params and duplicate in compose, fix port 8081 [FEAT] avoid unused params and duplicate in compose, fix port 8081 Jun 21, 2024
@Anton3 Anton3 changed the title [FEAT] avoid unused params and duplicate in compose, fix port 8081 feat configs: don't duplicate dbconnection in config_vars, pass it through env Jun 21, 2024
@Anton3 Anton3 merged commit 0405d00 into userver-framework:develop Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants