Improved use of GitHub Actions + pandas warning fix #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bedroesb
commented
Nov 29, 2024
•
bedroesb
commented
- Using GH Actions yo test for real by doing a draft submission, and a installation
- Automatic testing for python versions: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 and following OS versions: ubuntu-latest, macos-latest, windows-latest
- Add fix for pandas df type warning (closes dtype incompatible with float64 warning when writing to pandas df #100)
- Security fix for pyYAML (related to pyyaml 5.4.* is giving problems upon installation #97)
- Add/Fix Python 3.13 support
- Drop Python 3.7 support due to incompatibility issues
- Test on Multiple machines a real submission
|
This should also fix the deprecated dependency. |
|
Sorry I just noticed I still have to test some local changes I didn't push, sorry for the spam! |
|
@bgruening I don't understand why I didn't add all these test before, but at least they are now there ... :) |
bgruening
approved these changes
Dec 7, 2024
.github/workflows/python-app.yml
Outdated
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
I guess it would be enough if we test for the lower and upper bound?
ena_upload/ena_upload.py
Outdated
There was a problem hiding this comment.
This file is hard to review, I guess we trust the tests :)
There was a problem hiding this comment.
I wonder what went wrong with this file 🤔 I added multiple .Series(dtype='str') to keep Pandas happy
|
Cool, great stuff @bedroesb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.