Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesender updates #143

Merged
merged 12 commits into from
Oct 21, 2024
Merged

filesender updates #143

merged 12 commits into from
Oct 21, 2024

Conversation

TomHarrop
Copy link
Collaborator

@TomHarrop TomHarrop commented Oct 8, 2024

To do:

  • improve help text
    1. do users need an account for AARNet filesender? If so, how do they get one?
    2. where on AARNet do users find their credentials?
    3. where on Galaxy do they enter their credentials?
  • Fix from address

@GarethPrice-Aus
Copy link

Email notification to recipient comes in as "The following file has been uploaded to AARNet FileSenderhttps://filesender.aarnet.edu.au/ by [email protected]mailto:[email protected] and you have been granted permission to download its contents." Could we get the "galaxy-no-reply" address to reflect the Galaxy user that trigger the job?

@TomHarrop
Copy link
Collaborator Author

@madsi1m we have the filesender tool on dev. Tracking issues here, so if you make any changes you could PR them to this branch.

@madsi1m
Copy link
Contributor

madsi1m commented Oct 9, 2024

Email notification to recipient comes in as "The following file has been uploaded to AARNet FileSenderhttps://filesender.aarnet.edu.au/ by [email protected]mailto:[email protected] and you have been granted permission to download its contents." Could we get the "galaxy-no-reply" address to reflect the Galaxy user that trigger the job?

@TomHarrop you will need to change "[email protected]" to '$__user_email__'

@GarethPrice-Aus
Copy link

Nuwan found this - it could be adapted in part for the Help section of the tool:
https://site.usegalaxy.org.au/owncloud.html

@madsi1m
Copy link
Contributor

madsi1m commented Oct 14, 2024

@TomHarrop
Copy link
Collaborator Author

I've added some help text - see the screenshot ⬇️

@madsi1m / @GarethPrice-Aus let me know if there's anything you'd like to add or correct.


screenshot-localhost_9090-2024 10 21-16_18_06

]]></command>
<inputs>
<param name="data" type="data" format="txt,data" multiple="true" optional="false" label="Datasets to be sent:"/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mthang do you know if txt is necessary here? I removed it and it still let me send a text file. Just because "Select a dataset of type data,txt" looks weird to my eye.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomHarrop I would remove "txt" from the 'format. My understanding is the format data should already have the txt covered.

@GarethPrice-Aus
Copy link

Hi @TomHarrop Looks good. The text is clear and helpful. Thanks

@madsi1m
Copy link
Contributor

madsi1m commented Oct 21, 2024

nice

@TomHarrop
Copy link
Collaborator Author

tests passed locally

@TomHarrop TomHarrop merged commit c8e1e09 into usegalaxy-au:master Oct 21, 2024
1 check passed
@TomHarrop TomHarrop changed the title [DON'T MERGE] tracking changes to filesender filesender updates Oct 21, 2024
@TomHarrop TomHarrop deleted the filesender_mods branch October 22, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants