-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filesender updates #143
filesender updates #143
Conversation
Email notification to recipient comes in as "The following file has been uploaded to AARNet FileSenderhttps://filesender.aarnet.edu.au/ by [email protected]mailto:[email protected] and you have been granted permission to download its contents." Could we get the "galaxy-no-reply" address to reflect the Galaxy user that trigger the job? |
@madsi1m we have the filesender tool on dev. Tracking issues here, so if you make any changes you could PR them to this branch. |
@TomHarrop you will need to change |
Nuwan found this - it could be adapted in part for the Help section of the tool: |
@GarethPrice-Aus looks like that file is here: https://github.com/usegalaxy-au/galaxy-media-site/blob/dev/webapp/home/templates/home/pages/owncloud.html |
I've added some help text - see the screenshot ⬇️ @madsi1m / @GarethPrice-Aus let me know if there's anything you'd like to add or correct. |
]]></command> | ||
<inputs> | ||
<param name="data" type="data" format="txt,data" multiple="true" optional="false" label="Datasets to be sent:"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mthang do you know if txt
is necessary here? I removed it and it still let me send a text file. Just because "Select a dataset of type data,txt" looks weird to my eye.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomHarrop I would remove "txt" from the 'format. My understanding is the format data should already have the txt covered.
Hi @TomHarrop Looks good. The text is clear and helpful. Thanks |
nice |
tests passed locally |
To do: