-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pg-post-tasks and add common bash variable and functions #1700
Remove pg-post-tasks and add common bash variable and functions #1700
Conversation
d5058c0
to
98be3b5
Compare
Hi @jlqfab, we can add other common bash variables here as well like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
@cat-bro besides the |
7e82147
to
bbb00b7
Compare
bbb00b7
to
3c003f6
Compare
The perfect is the enemy of the decent, this is probably good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Remove time-consuming pg-post-tasks role and put its tasks into the common role in a more efficient form. If there are environment variables which need to be the same for all users, these can be set in one common file.
Add bash functions for all users
jwd
,go-jwd
and others. We can add more of these and ones that are helpful on pulsar VMS, useful aliases etc over time.Add a tag
users
to the tasks that loop over all the users so that they can be easily skipped.