Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pg-post-tasks and add common bash variable and functions #1700

Merged

Conversation

cat-bro
Copy link
Collaborator

@cat-bro cat-bro commented Dec 22, 2023

Remove time-consuming pg-post-tasks role and put its tasks into the common role in a more efficient form. If there are environment variables which need to be the same for all users, these can be set in one common file.

Add bash functions for all users jwd, go-jwd and others. We can add more of these and ones that are helpful on pulsar VMS, useful aliases etc over time.

Add a tag users to the tasks that loop over all the users so that they can be easily skipped.

@cat-bro cat-bro marked this pull request as draft December 22, 2023 02:34
@cat-bro cat-bro force-pushed the bashrc_functions_and_variables_for_everyone branch from d5058c0 to 98be3b5 Compare December 22, 2023 06:10
@cat-bro cat-bro requested a review from jlqfab January 14, 2024 23:16
@cat-bro
Copy link
Collaborator Author

cat-bro commented Jan 14, 2024

Hi @jlqfab, we can add other common bash variables here as well like export EDITOR=vim. This is not ready for merge because I'd like to add a few more things such as a jwd function for pulsar

jlqfab
jlqfab previously approved these changes Jan 14, 2024
Copy link
Collaborator

@jlqfab jlqfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@jlqfab
Copy link
Collaborator

jlqfab commented Jan 14, 2024

@cat-bro besides the EDITOR export, I like to change the defaults in the .bashrc for HISTSIZE and HISTFILESIZE, so that history doesn't get erased too quickly (1000 lines of history is exceeded very quickly).

@cat-bro cat-bro force-pushed the bashrc_functions_and_variables_for_everyone branch 2 times, most recently from 7e82147 to bbb00b7 Compare January 16, 2025 05:00
@cat-bro cat-bro force-pushed the bashrc_functions_and_variables_for_everyone branch from bbb00b7 to 3c003f6 Compare January 16, 2025 05:01
@cat-bro cat-bro marked this pull request as ready for review January 16, 2025 05:06
@cat-bro
Copy link
Collaborator Author

cat-bro commented Jan 16, 2025

The perfect is the enemy of the decent, this is probably good to go

jlqfab
jlqfab previously approved these changes Jan 16, 2025
Copy link
Collaborator

@jlqfab jlqfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

hosts Outdated Show resolved Hide resolved
@jlqfab jlqfab merged commit c258cd3 into usegalaxy-au:master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants