-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render the components as partials. #399
base: develop
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/monocompany/bedrock/mKvequ1nraX62q72pesRr5S7i92c |
Very cool! 😍 To merge PR the functionality I would like it to be behind a flag. What if the logic of putting it behind the If you could implement a config flag that enables this option separately (e.g. Then we can default it to |
Done. (It was actually not behind de (When you change the doc, note that the doc talks about |
@thusc OK, noted! |
2dfe4ac
to
f789b13
Compare
See #391 for a discussion.
This is currently only done in the
build
step, and not for the the live development server.Let me know if you prefer to have the code for the live development server in the same PR; I guess I can have a look at it too.
And maybe you'd like an example use case with htmx before merging ? Or small PRs like these are fine ?
(Btw this is extracted and modified form the https://github.com/thusc/bedrock/tree/cli branch you saw before, but maybe this one will take more time and I prefer to separate different features.)
Here is an example file:
Edit: here is the same example on the automated Vercel deployment: https://bedrock-git-fork-thusc-render-partials-monocompany.vercel.app/partials/cc-example/01-my-component.html