feat: use-inkathon dns frontend example
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating both PR's to illustrate the different approaches. I agree with you in that this PR is way simpler and easier to maintain. Let's go with this approach. Can you close the other one and make this one ready for review? |
peetzweg
changed the title
useinkathon hooks library onlyuse-inkathon dns frontend example
cmichi
approved these changes
Jan 31, 2024
|
@cmichi great idea, added the video as a gif to the readme of the example. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part is meant to be compared with #55 .
Adds frontend example with just the hooks library of
inkathoncalleduseinkathon, which is a similar library to theuseinklibrary used in the other examples.This example demonstrate a very minimal dapp setup. Not deployment scripts or component libraries used here.
Personally I would enjoy an example like this more than #55 as especially for beginners the inkathon template can be very overwhelming and not yield a quick success if not experienced with the tools chosen by the inkathon template.
https://github.com/paritytech/ink-examples/blob/344f0b1bbcff27a7c8ed2e2f95a6cc61644f8d3a/dns/frontend/package.json#L12-L17
useinkathon-small.mov