Remove is_ghe_start_loop from schema
#280
Open
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanushree04 the test failure is from the OpenStudio rake task, which is being resolved in the OS 3.9 update. Ignore it for now. The Rspec tests pass locally for me. |
mitchute
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #[issue number here]
Pull Request Description
This setting needed to be manually set in the geojson file, and it needed to be on the correct ThermalJunction. I figured out a way to remove it altogether in ThermalNetwork, so here I'm removing it from the schema (and test files) so it doesn't accidentally get used.
Checklist (Delete lines that don't apply)