[VEL-2319] Convert to pnpm #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
requested review from
Miexil,
JulienVannier66 and
a team
as code owners
phndiaye
commented
Jan 30, 2024
Comment on lines
+12
to
+21
| run(() => { | ||
| assert( | ||
| '[helper][log-activity] An action is required for this helper to work properly.', | ||
| typeof action === 'function' | ||
| ); | ||
| assert( | ||
| '[helper][log-activity] An actionDescription needs to be passed for the activity-log to make sense.', | ||
| typeof actionDescription === 'string' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
LIAR ! 😂
I don't believe in any fix for the param assertions ^^
Miexil
approved these changes
Jan 30, 2024
Comment on lines
+12
to
+21
| run(() => { | ||
| assert( | ||
| '[helper][log-activity] An action is required for this helper to work properly.', | ||
| typeof action === 'function' | ||
| ); | ||
| assert( | ||
| '[helper][log-activity] An actionDescription needs to be passed for the activity-log to make sense.', | ||
| typeof actionDescription === 'string' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
LIAR ! 😂
I don't believe in any fix for the param assertions ^^
upfluence-bot
added
reviewed/ready-to-merge
and removed
reviewed/needs-review
reviewed/ready-to-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate package manager from yarn to pnpm.
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist