Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartStopEventWrapper #7137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Each sensor class has its own implementation of event start/stop management.

What is the new behavior?

Using shared start/stop infrastructure, which is covered by tests.

PR Checklist

Please check if your PR fulfills the following requirements:

@MartinZikmund MartinZikmund requested a review from a team September 19, 2021 15:19
@gitpod-io
Copy link

gitpod-io bot commented Sep 19, 2021

@MartinZikmund MartinZikmund self-assigned this Sep 19, 2021
@MartinZikmund MartinZikmund marked this pull request as draft September 19, 2021 15:19
@MartinZikmund MartinZikmund force-pushed the dev/mazi/startstopevent-sensors branch from 1c424c0 to 890b846 Compare September 19, 2021 15:20
@MartinZikmund MartinZikmund changed the title Using StartStopDelegateWrapper for sensors [WIP] Using StartStopDelegateWrapper for sensors Sep 19, 2021
@MartinZikmund MartinZikmund force-pushed the dev/mazi/startstopevent-sensors branch from 2357048 to 9199193 Compare August 26, 2024 13:47
@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Aug 26, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-7137/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/startstopevent-sensors branch from 9199193 to cefa833 Compare December 26, 2024 17:38
@MartinZikmund MartinZikmund force-pushed the dev/mazi/startstopevent-sensors branch from cefa833 to 5c8326e Compare December 26, 2024 17:39
@github-actions github-actions bot removed platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Dec 26, 2024
@MartinZikmund MartinZikmund changed the title [WIP] Using StartStopDelegateWrapper for sensors StartStopDelegateWrapper Dec 26, 2024
@MartinZikmund MartinZikmund marked this pull request as ready for review December 26, 2024 17:40
@MartinZikmund MartinZikmund changed the title StartStopDelegateWrapper StartStopEventWrapper Dec 26, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-7137/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants