Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dragdrop): fire DragEnter and DragOver when firing DragStarting #18812

Merged

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes https://github.com/unoplatform/brain-products-private/issues/7

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ramezgerges ramezgerges requested a review from dr1rrb November 15, 2024 19:53
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18812/index.html

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Nov 20, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 147903 has failed on Uno.UI - CI.

@dr1rrb
Copy link
Member

dr1rrb commented Nov 22, 2024

@ramezgerges we have some tests that are failing on Android https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=3142203&_a=resultQuery

image

Could you have a look? Might be just a a too strict tests that does not allow to get an additional event and which should be updated accordingly :)

@github-actions github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Nov 25, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148380 has failed on Uno.UI - CI.

@ramezgerges ramezgerges force-pushed the dragenter_with_dragstarting branch from a55b43b to 75adc10 Compare November 26, 2024 15:31
@github-actions github-actions bot removed the area/automation Categorizes an issue or PR as relevant to project automation label Nov 26, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18812/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18812/index.html

@ramezgerges ramezgerges merged commit 164d808 into unoplatform:master Nov 27, 2024
114 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants