Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MenuFlyout support for keyboard accelerators #17228

Closed
wants to merge 28 commits into from

chore: New hiding

83f6063
Select commit
Loading
Failed to load commit list.
Closed

feat: MenuFlyout support for keyboard accelerators #17228

chore: New hiding
83f6063
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Uno.UI - CI failed Aug 25, 2024 in 1h 7m 7s

Build #5.4.0-PullRequest-17228-137405-17228.1610 had test failures

Details

Tests

  • Failed: 113 (0.22%)
  • Passed: 45,898 (90.50%)
  • Other: 4,706 (9.28%)
  • Total: 50,717

Annotations

Check failure on line 113 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

Build log #L113

Bash exited with code '1'.

Check failure on line 19 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

Build log #L19

There are one or more test failures detected in result files. Detailed summary of published test results can be viewed in the Tests tab.

Check failure on line 23 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

Build log #L23

There are one or more test failures detected in result files. Detailed summary of published test results can be viewed in the Tests tab.

Check failure on line 26 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

Build log #L26

There are one or more test failures detected in result files. Detailed summary of published test results can be viewed in the Tests tab.

Check failure on line 1 in When_Visibility_Changes()

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

When_Visibility_Changes()

Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.AreEqual failed. Expected a difference no greater than <1> between expected value <100> and actual value <1>. Checking width when collapsed for Microsoft.UI.Xaml.Controls.MenuFlyoutSubItem
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.ThrowAssertFailed(String assertionName, String message)
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.AreEqual(Double expected, Double actual, Double delta, String message, Object[] parameters)
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.AreEqual(Double expected, Double actual, Double delta, String message)
   at Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Controls.Given_Control_Visibility.When_Visibility_Changes()
   at Uno.UI.Samples.Tests.UnitTestsControl.<>c__DisplayClass63_1.<<ExecuteTestsForInstance>g__InvokeTestMethod|4>d.MoveNext()

Check failure on line 1 in When_Stretch(None, False)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

When_Stretch(None, False)

Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.Fail failed. ImageAssert.HasColorAt @ line 109
====================
Color at (50,6) is not expected
expected: FF0ED145 #FF0ED145
actual  : 00000000 #00000000
tolerance: 28
difference: 255

   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.ThrowAssertFailed(String assertionName, String message)
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Fail(String message, Object[] parameters)
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Fail(String message)
   at Uno.UI.RuntimeTests.Helpers.ImageAssert.HasColorAtImpl(RawBitmap screenshot, Int32 x, Int32 y, Color expectedColor, Byte tolerance, Int32 line)
   at Uno.UI.RuntimeTests.Helpers.ImageAssert.HasColorAt(RawBitmap screenshot, Single x, Single y, String expectedColorCode, Byte tolerance, Int32 line)
   at Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Media.Given_ImageBrush.When_Stretch(Stretch stretch, Boolean useRectangle)
   at Uno.UI.Samples.Tests.UnitTestsControl.<>c__DisplayClass63_1.<<ExecuteTestsForInstance>g__InvokeTestMethod|4>d.MoveNext()

Check failure on line 1 in ValidateKeyboardAcceleratorEventNotInvokedWhenCollapsed()

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

ValidateKeyboardAcceleratorEventNotInvokedWhenCollapsed()

Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.Fail failed. Event 'Invoked' was not raised before timeout.
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.ThrowAssertFailed(String assertionName, String message) in /_/src/TestFramework/TestFramework/Assertions/Assert.cs:line 60
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Fail(String message, Object[] parameters) in /_/src/TestFramework/TestFramework/Assertions/Assert.Fail.cs:line 54
   at Common.Verify.Fail(String message, Object[] args) in C:\a\1\s\src\Uno.UI.RuntimeTests\MUX\Utilities\MSTestInterop.cs:line 161
   at Microsoft.UI.Xaml.Tests.Common.EventTester`2.Wait(TimeSpan timeout) in C:\a\1\s\src\Uno.UI.RuntimeTests\MUX\Helpers\EventTester.cs:line 269
   at Microsoft.UI.Xaml.Tests.Common.EventTester`2.Wait() in C:\a\1\s\src\Uno.UI.RuntimeTests\MUX\Helpers\EventTester.cs:line 261
   at Uno.UI.RuntimeTests.MUX.Input.KeyboardAccelerators.KeyboardAcceleratorTests.ValidateKeyboardAcceleratorEventNotInvokedWhenCollapsed() in C:\a\1\s\src\Uno.UI.RuntimeTests\MUX\Input\KeyboardAccelerators\KeyboardAcceleratorTests.cs:line 460
   at Uno.UI.Samples.Tests.UnitTestsControl.<>c__DisplayClass63_1.<<ExecuteTestsForInstance>g__InvokeTestMethod|4>d.MoveNext() in C:\a\1\s\src\SamplesApp\SamplesApp.UnitTests.Shared\Controls\UnitTest\UnitTestsControl.cs:line 900

Check failure on line 1 in VerifyListViewContextFlyoutCanInvokeHiddenAccelerator()

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Uno.UI - CI

VerifyListViewContextFlyoutCanInvokeHiddenAccelerator()

System.NullReferenceException: Object reference not set to an instance of an object
   at Microsoft.UI.Xaml.Tests.Common.EventTester`2[[Microsoft.UI.Xaml.UIElement, Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null],[Microsoft.UI.Xaml.RoutedEventArgs, Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null]]..ctor(UIElement sender, String eventName, Action`2 action)
   at Microsoft.UI.Xaml.Tests.Common.EventTester`2[[Microsoft.UI.Xaml.UIElement, Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null],[Microsoft.UI.Xaml.RoutedEventArgs, Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null]]..ctor(UIElement sender, String eventName)
   at Uno.UI.RuntimeTests.MUX.Input.Focus.FocusHelper.EnsureFocusAsync(UIElement element, FocusState focusState, UInt32 Attempts)
   at Uno.UI.RuntimeTests.MUX.Input.KeyboardAccelerators.KeyboardAcceleratorTests.VerifyListViewContextFlyoutCanInvokeHiddenAccelerator()
   at Uno.UI.Samples.Tests.UnitTestsControl.<>c__DisplayClass63_1.<<ExecuteTestsForInstance>g__InvokeTestMethod|4>d.MoveNext()