Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Avoid directly implementing ISensorEventListener on SimpleOrientationSensor on Android #12224

Conversation

Youssef1313
Copy link
Member

BREAKING CHANGE: Avoid directly implementing ISensorEventListener on SimpleOrientationSensor on Android

GitHub Issue (If applicable): Part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

…ientationSensor` on Android

BREAKING CHANGE: Avoid directly implementing `ISensorEventListener` on `SimpleOrientationSensor` on Android
@github-actions github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label May 9, 2023
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label May 9, 2023
@Youssef1313 Youssef1313 requested a review from jeromelaban May 10, 2023 10:47
@jeromelaban jeromelaban merged commit 803ce8e into unoplatform:feature/breaking-changes May 10, 2023
@Youssef1313 Youssef1313 deleted the simple-orientation-sensor-interface branch May 10, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleOrientationSensor shouldn't directly implement ISensorEventListener
2 participants