Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)!: Fix AnalyticsInfo.DeviceForm returning mobile instead of tablet #12058

Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 24, 2023

GitHub Issue (If applicable): closes #12045, part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Apr 24, 2023
@Youssef1313 Youssef1313 marked this pull request as draft April 24, 2023 20:05
@Youssef1313
Copy link
Member Author

Will be for 5.0

@Youssef1313 Youssef1313 changed the base branch from master to feature/breaking-changes May 10, 2023 11:07
@Youssef1313 Youssef1313 marked this pull request as ready for review May 10, 2023 11:10
@Youssef1313 Youssef1313 changed the title fix(android): Fix AnalyticsInfo.DeviceForm returning mobile instead of tablet fix(android)!: Fix AnalyticsInfo.DeviceForm returning mobile instead of tablet May 10, 2023
@jeromelaban jeromelaban merged commit adb352d into unoplatform:feature/breaking-changes May 17, 2023
@Youssef1313 Youssef1313 deleted the issues/12045 branch May 17, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] AnalyticsInfo DeviceFamily returns as Mobile on Tablet device
2 participants