Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix items dependency property propagation in ListView items #1064

Merged
merged 6 commits into from
Jun 19, 2019

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): fixes #1009 , closes #827

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The ListView items on iOS do not have a parent, making ElementName bindings as well as xaml events handlers not working.

PR Checklist

Please check if your PR fulfills the following requirements:

@jeromelaban jeromelaban force-pushed the dev/jela/ios-xaml-parent branch from e7951bb to e14a8a1 Compare June 12, 2019 19:50
@ghuntley ghuntley force-pushed the dev/jela/ios-xaml-parent branch from 7ddfc7a to fc43b72 Compare June 19, 2019 05:28
@ghuntley ghuntley added ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform kind/bug Something isn't working labels Jun 19, 2019
@jeromelaban jeromelaban merged commit 95af420 into master Jun 19, 2019
@jeromelaban jeromelaban deleted the dev/jela/ios-xaml-parent branch June 19, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events of items of ListView are not invoked
4 participants