Merge pull request #12274 from Youssef1313/mediaplayerelement-disposable

fix!: `MediaPlayerElement` shouldn't be `IDisposable`
unoplatform · May 13, 2023 · b4cb2e0 · b4cb2e0
2 parents 1253ad9 + 2a19504
commit b4cb2e0
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/src/Uno.UI/UI/Xaml/Controls/MediaPlayerElement/MediaPlayerElement.cs b/src/Uno.UI/UI/Xaml/Controls/MediaPlayerElement/MediaPlayerElement.cs
@@ -13,11 +13,6 @@ namespace Windows.UI.Xaml.Controls
 	[TemplatePart(Name = MediaPlayerPresenterName, Type = typeof(MediaPlayerPresenter))]
 	[TemplatePart(Name = LayoutRootName, Type = typeof(Grid))]
 	public partial class MediaPlayerElement
-#if __IOS__ || __ANDROID__ || __MACOS__
-		// To avoid causing FrameworkElement.Dispose to become virtual (and cause a breaking change),
-		// we keep the disposable for existing platforms, but we don't implement it for the other targets.
-		: IDisposable
-#endif
 	{
 		private const string PosterImageName = "PosterImage";
 		private const string TransportControlsPresenterName = "TransportControlsPresenter";