Skip to content

Commit

Permalink
chore: Forward port 5.5 changes
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromelaban committed Nov 15, 2024
2 parents 3e576c0 + 63a9f22 commit 92b643a
Show file tree
Hide file tree
Showing 32 changed files with 136 additions and 68 deletions.
14 changes: 10 additions & 4 deletions build/ci/.azure-devops-project-template-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ jobs:
artifactName: 'Nuget_Packages'

- template: templates/gitversion.yml

- template: templates/dotnet-mobile-install-windows.yml
- template: templates/uno-dev-feed.yml

- script: copy $(System.ArtifactsDirectory)\Nuget_Packages\vslatest\*.nupkg $(Build.SourcesDirectory)\src\PackageCache
displayName: Copy Artifacts to PackageCache
Expand Down Expand Up @@ -103,6 +103,7 @@ jobs:
xCodeRoot: ${{ parameters.xCodeRoot }}

- template: templates/dotnet-mobile-install-mac.yml
- template: templates/uno-dev-feed.yml

- powershell: cp $(System.ArtifactsDirectory)/Nuget_Packages/vslatest/*.nupkg $(Build.SourcesDirectory)/src/PackageCache
displayName: Copy Artifacts to PackageCache
Expand Down Expand Up @@ -134,6 +135,12 @@ jobs:
TestGroup: '1'
group_2:
TestGroup: '2'
group_3:
TestGroup: '3'

variables:
# don't validate transitive dependencies for template tests
NuGetAuditMode: direct

variables:
# don't validate transitive dependencies for template tests
Expand All @@ -145,11 +152,10 @@ jobs:
artifactName: 'Nuget_Packages'

- template: templates/gitversion.yml

- template: templates/dotnet-mobile-install-linux.yml

- template: templates/gitversion.yml

- template: templates/uno-dev-feed.yml

- script: cp $(System.ArtifactsDirectory)/Nuget_Packages/vslatest/*.nupkg $(Build.SourcesDirectory)/src/PackageCache
displayName: Copy Artifacts to PackageCache

Expand Down
7 changes: 7 additions & 0 deletions build/ci/templates/uno-dev-feed.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
parameters:
nugetPackages: '$(Pipeline.Workspace)/.nuget/packages'

steps:

- pwsh: dotnet nuget add source https://pkgs.dev.azure.com/uno-platform/1dd81cbd-cb35-41de-a570-b0df3571a196/_packaging/unoplatformdev/nuget/v3/index.json -n "uno-dev"
displayName: Add dev feed source
22 changes: 11 additions & 11 deletions build/test-scripts/run-net7-template-linux.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ $projects =
@(0, "5.1/uno51blank/uno51blank.Wasm/uno51blank.Wasm.csproj", @(), @()),

# 5.1 Recommended
@(0, "5.1/uno51recommended/uno51recommended.Skia.Gtk/uno51recommended.Skia.Gtk.csproj", @(), @()),
@(0, "5.1/uno51recommended/uno51recommended.Skia.Linux.FrameBuffer/uno51recommended.Skia.Linux.FrameBuffer.csproj", @(), @()),
@(0, "5.1/uno51recommended/uno51recommended.Skia.WPF/uno51recommended.Skia.WPF.csproj", @(), @()),
@(0, "5.1/uno51recommended/uno51recommended.Wasm/uno51recommended.Wasm.csproj", @(), @()),
@(0, "5.1/uno51recommended/uno51recommended.Server/uno51recommended.Server.csproj", @(), @()),
@(0, "5.1/uno51recommended/uno51recommended.Tests/uno51recommended.Tests.csproj", @(), @()),
@(0, "5.1/uno51recommended/uno51recommended.UITests/uno51recommended.UITests.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.Skia.Gtk/uno51recommended.Skia.Gtk.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.Skia.Linux.FrameBuffer/uno51recommended.Skia.Linux.FrameBuffer.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.Skia.WPF/uno51recommended.Skia.WPF.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.Wasm/uno51recommended.Wasm.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.Server/uno51recommended.Server.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.Tests/uno51recommended.Tests.csproj", @(), @()),
@(1, "5.1/uno51recommended/uno51recommended.UITests/uno51recommended.UITests.csproj", @(), @()),

# 5.2 Blank
@(1, "5.2/uno52blank/uno52blank/uno52blank.csproj", @(), @()),
Expand All @@ -69,16 +69,16 @@ $projects =
@(1, "5.2/uno52Lib/uno52Lib.csproj", @(), @()),

# 5.2 Uno NuGet Lib
@(1, "5.2/uno52NuGetLib/uno52NuGetLib.csproj", @(), @()),
@(2, "5.2/uno52NuGetLib/uno52NuGetLib.csproj", @(), @()),

# 5.2 Uno SingleProject Lib
@(1, "5.2/uno52SingleProjectLib/uno52SingleProjectLib.csproj", @(), @()),
@(2, "5.2/uno52SingleProjectLib/uno52SingleProjectLib.csproj", @(), @()),

# 5.2 Uno App with Library reference
@(1, "5.2/uno52AppWithLib/uno52AppWithLib/uno52AppWithLib.csproj", @(), @()),
@(2, "5.2/uno52AppWithLib/uno52AppWithLib/uno52AppWithLib.csproj", @(), @()),

# 5.3 Blank with net9
@(2, "5.3/uno53net9blank/uno53net9blank/uno53net9blank.csproj", @(), @())
@(3, "5.3/uno53net9blank/uno53net9blank/uno53net9blank.csproj", @(), @())

# 5.3 blank publish testing
# Disabled for LXD setup issues
Expand Down
14 changes: 7 additions & 7 deletions build/test-scripts/run-netcore-mobile-template-tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -271,16 +271,16 @@ $projects =
@(1, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-desktop", $sdkFeatures), @("macOS", "NetCore")),

# Default mode for the template is WindowsAppSDKSelfContained=true, which requires specifying a target platform.
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.19041"), @()),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:Platform=arm64" , "-p:TargetFramework=net8.0-windows10.0.19041"), @()),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.26100"), @()),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:Platform=arm64" , "-p:TargetFramework=net8.0-windows10.0.26100"), @()),

# Ensure that default without platform builds properly
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:TargetFramework=net8.0-windows10.0.19041"), @()),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:TargetFramework=net8.0-windows10.0.26100"), @()),

# Validate building inside VS
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:BuildingInsideVisualStudio=true"), @("NetCore")),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:BuildingInsideVisualStudio=true", "-p:_UnoSelectedTargetFramework=net8.0-desktop"), @("NetCore")),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:BuildingInsideVisualStudio=true", "-p:_UnoSelectedTargetFramework=net8.0-windows10.0.19041"), @()),
@(2, "5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:BuildingInsideVisualStudio=true", "-p:_UnoSelectedTargetFramework=net8.0-windows10.0.26100"), @()),

#
# 5.2 Uno Lib
Expand All @@ -301,7 +301,7 @@ $projects =
@(2, "5.2/uno52NuGetLib/uno52NuGetLib.csproj", @(), @("macOS", "NetCore")),

# Default mode for the template is WindowsAppSDKSelfContained=true, which requires specifying a target platform.
@(2, "5.2/uno52Lib/uno52Lib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.19041"), @("macOS")),
@(2, "5.2/uno52Lib/uno52Lib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.26100"), @("macOS")),

#
# 5.2 Uno SingleProject Lib
Expand All @@ -314,7 +314,7 @@ $projects =
@(2, "5.2/uno52SingleProjectLib/uno52SingleProjectLib.csproj", @("-f", "net8.0-desktop"), @("macOS", "NetCore")),

# Default mode for the template is WindowsAppSDKSelfContained=true, which requires specifying a target platform.
@(2, "5.2/uno52SingleProjectLib/uno52SingleProjectLib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.19041"), @()),
@(2, "5.2/uno52SingleProjectLib/uno52SingleProjectLib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.26100"), @()),

# 5.2 Uno App with Library reference
@(2, "5.2/uno52AppWithLib/uno52AppWithLib/uno52AppWithLib.csproj", @("-f", "net8.0"), @("macOS", "NetCore")),
Expand All @@ -339,7 +339,7 @@ $projects =
@(3, "5.3/uno53net9blank/uno53net9blank/uno53net9blank.csproj", @("-f", "net9.0-desktop", $sdkFeatures), @("macOS", "NetCore")),

# Default mode for the template is WindowsAppSDKSelfContained=true, which requires specifying a target platform.
@(4, "5.2/uno52AppWithLib/uno52AppWithLib/uno52AppWithLib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.19041"), @()),
@(4, "5.2/uno52AppWithLib/uno52AppWithLib/uno52AppWithLib.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.26100"), @()),

# Publishing validation
@(4, "5.3/uno53net9blank/uno53net9blank/uno53net9blank.csproj", @("-f", "net9.0-desktop", "-p:PackageFormat=app"), @("OnlyMacOS", "NetCore", "Publish"))
Expand Down
4 changes: 2 additions & 2 deletions doc/articles/features/working-with-xaml-hot-reload.md
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ Mobile targets are currently using a limited version of XAML Hot Reload and do n

## Hot Reload Indicator

Hot Reload displays a visual indicator to help you further monitor changes while developing. It displays new information every time Hot Reload is triggered. The indicator is enabled by default within the `EnableHotReload()` method which is located in the root `App.xaml.cs` file. This displays an overlay which hosts the visual indicator. If you wish to disable it, you simply have to provide the following boolean: `EnableHotReload(disableIndicator: true)`, removing the overlay from the view.
Hot Reload displays a visual indicator to help you further monitor changes while developing. It displays new information every time Hot Reload is triggered. The indicator is enabled by default within the `UseStudio()` method which is located in the root `App.xaml.cs` file. This displays an overlay which hosts the visual indicator. If you wish to disable it, you simply have to provide the following boolean: `EnableHotReload(disableIndicator: true)`, removing the overlay from the view.

<p align="center">
<img src="../Assets/features/hotreload/indicator.png" alt="A hot reload visual indicator" />
Expand Down Expand Up @@ -370,7 +370,7 @@ Here's a summary of what icons and statuses you can expect:
//... in the OnLaunched method

#if DEBUG
MainWindow.EnableHotReload();
MainWindow.UseStudio();
#endif
```

Expand Down
4 changes: 4 additions & 0 deletions doc/articles/migrating-from-previous-releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ A few considerations to take into account:
- Moving to .NET 9 or upgrading .NET 9 projects now require the use of .NET 9 RC2 and Visual Studio 17.12 Preview 3.
- To migrate a project to .NET 9, [read the directions](xref:Uno.Development.MigratingFromNet8ToNet9) from our documentation.

### The EnableHotReload method is deprecated

When upgrading to Uno 5.5, in the `App.xaml.cs` file, the `EnableHotReload()` method is deprecated and must be replaced with `UseStudio()` instead.

## Uno Platform 5.4

Uno Platform 5.4 contains breaking changes for Uno.Extensions.
Expand Down
2 changes: 1 addition & 1 deletion doc/articles/migrating-to-uno-5.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Hot Reload support has changed in Uno Platform 5.0 and a new API invocation is n
//... in the OnLaunched method

#if DEBUG
MainWindow.EnableHotReload();
MainWindow.UseStudio();
#endif
```

Expand Down
12 changes: 12 additions & 0 deletions doc/articles/uno-build-error-codes.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,18 @@ Some components like `ProgressRing` and `MediaPlayerElement` requires you to ref
- For `ProgressRing`, it requires Lottie dependency. For more information about adding Lottie to your project, see [Lottie for Uno](xref:Uno.Features.Lottie).
- For `MediaPlayerElement` on WebAssembly or Gtk, it requires `Uno.WinUI.MediaPlayer.WebAssembly` or `Uno.WinUI.MediaPlayer.Skia.Gtk` NuGet package. For more information, see [MediaPlayerElement](xref:Uno.Controls.MediaPlayerElement).

### UNO0008

In Uno Platform 5.5, the `EnableHotReload` method has been deprecated and replaced by `UseStudio()`.

Note that this change only applies to projects using the Uno.Sdk. If you're not using the Uno.Sdk, you can disable this warning using the following code:

```xml
#pragma warning disable UNO0008 // Replace with UseStudio() when migrating to the Uno.Sdk.
window.EnableHotReload();
#pragma warning restore UNO0008
```

## XAML Errors

### UNOX0001
Expand Down
3 changes: 3 additions & 0 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@

<!-- Workaround for https://github.com/dotnet/runtime/issues/103205 -->
<NoWarn>$(NoWarn);CS0436</NoWarn>

<!-- Required for studio -->
<NoWarn>$(NoWarn);UNO0008</NoWarn>

<!-- On CI, UWP source is generated in a job running on Windows (CRLF EOLs). -->
<!-- When the artifacts are downloaded in a job running on Linux, IDE0055 will complain (expecting LF EOLs) -->
Expand Down
22 changes: 11 additions & 11 deletions src/SolutionTemplate/5.1/uno51blank/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@
<PackageVersion Include="Microsoft.Windows.Compatibility" Version="8.0.0" />
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.2428" />
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="1.4.240211001" />
<PackageVersion Include="SkiaSharp.NativeAssets.Android" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.iOS" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.MacCatalyst" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.macOS" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Skottie" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Views.Uno.WinUI" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Views" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Views.Gtk2" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.Android" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.iOS" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.MacCatalyst" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.macOS" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Skottie" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Views.Uno.WinUI" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Views" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Views.Gtk2" Version="2.88.9-preview.2.2" />
<PackageVersion Include="OpenTK" Version="3.1.0" />
<PackageVersion Include="OpenTK.GLControl" Version="3.1.0" />
<PackageVersion Include="Uno.Core.Extensions.Logging.Singleton" Version="4.0.1" />
Expand Down
2 changes: 2 additions & 0 deletions src/SolutionTemplate/5.1/uno51blank/uno51blank/App.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ protected override void OnLaunched(LaunchActivatedEventArgs args)
MainWindow = new Window();

#if DEBUG
#pragma warning disable UNO0008
MainWindow.EnableHotReload();
#pragma warning restore UNO0008
#endif


Expand Down
28 changes: 14 additions & 14 deletions src/SolutionTemplate/5.1/uno51recommended/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.2428" />
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="1.4.240211001" />
<PackageVersion Include="Serilog.AspNetCore" Version="8.0.1" />
<PackageVersion Include="SkiaSharp.NativeAssets.Android" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.iOS" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.MacCatalyst" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.macOS" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Skottie" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Views.Uno.WinUI" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Views" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.Views.Gtk2" Version="2.88.7" />
<PackageVersion Include="SkiaSharp.NativeAssets.Android" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.iOS" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Linux" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.MacCatalyst" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.macOS" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Skottie" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Views.Uno.WinUI" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Views" Version="2.88.9-preview.2.2" />
<PackageVersion Include="SkiaSharp.Views.Gtk2" Version="2.88.9-preview.2.2" />
<PackageVersion Include="OpenTK" Version="3.1.0" />
<PackageVersion Include="OpenTK.GLControl" Version="3.1.0" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="6.5.0" />
Expand All @@ -52,10 +52,10 @@
<PackageVersion Include="Uno.Extensions.Serialization" Version="4.0.0" />
<PackageVersion Include="Uno.Extensions.Serialization.Http" Version="4.0.0" />
<PackageVersion Include="Uno.Extensions.Serialization.Refit" Version="4.0.0" />
<PackageVersion Include="Uno.Material.WinUI" Version="4.1.1" />
<PackageVersion Include="Uno.Material.WinUI" Version="5.0.13" />
<PackageVersion Include="Uno.Dsp.Tasks" Version="1.3.0" />
<PackageVersion Include="Uno.Toolkit.WinUI" Version="5.1.5" />
<PackageVersion Include="Uno.Toolkit.WinUI.Material" Version="5.1.5" />
<PackageVersion Include="Uno.Toolkit.WinUI" Version="6.3.5" />
<PackageVersion Include="Uno.Toolkit.WinUI.Material" Version="6.3.5" />
<PackageVersion Include="Uno.Resizetizer" Version="1.3.0" />
<PackageVersion Include="Uno.UI.Adapter.Microsoft.Extensions.Logging" Version="$(UnoVersion)" />
<PackageVersion Include="Uno.UniversalImageLoader" Version="1.9.37" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ protected async override void OnLaunched(LaunchActivatedEventArgs args)
MainWindow = builder.Window;

#if DEBUG
#pragma warning disable UNO0008
MainWindow.EnableHotReload();
#pragma warning restore UNO0008
#endif

Host = await builder.NavigateAsync<Shell>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ protected override void OnLaunched(LaunchActivatedEventArgs args)
{
MainWindow = new Window();
#if DEBUG
#pragma warning disable UNO0008
MainWindow.EnableHotReload();
#pragma warning restore UNO0008
#endif


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<TargetFrameworks>net8.0-browserwasm;net8.0-desktop;net8.0</TargetFrameworks>
<TargetFrameworks Condition="!$([MSBuild]::IsOSPlatform('linux'))">$(TargetFrameworks);net8.0-android;net8.0-ios;net8.0-maccatalyst;net8.0-desktop</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.19041</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.26100</TargetFrameworks>

<!-- Disable android on msbuild .NET Framework until android 35 is supported -->
<TargetFrameworks Condition="'$(MSBuildRuntimeType)' == 'Full'">$(TargetFrameworks.Replace('net8.0-android',''))</TargetFrameworks>
Expand Down Expand Up @@ -52,7 +52,7 @@
BeforeTargets="AfterBuild">

<ItemGroup
Condition=" '$(TargetFramework)' == 'net8.0-windows10.0.19041' OR '$(TargetFramework)' == 'net8.0-desktop' ">
Condition=" '$(TargetFramework)' == 'net8.0-windows10.0.26100' OR '$(TargetFramework)' == 'net8.0-desktop' ">
<!-- Validates that assets are properly propagated to the output folder, regardless of their "copy to output" value -->
<_AssetsToValidate Include="$(OutputPath)Assets\SharedAssets.md" />
<_AssetsToValidate Include="$(OutputPath)Assets\Icons\icon_foreground.png" />
Expand Down
Loading

0 comments on commit 92b643a

Please sign in to comment.