build: add optional USE_EXTERNAL_LIBDEFLATE #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first build rule is the default rule.
When using = instead of := the variable is set when its used and not when its set. This prvents pkg-config from being run even when the value of the variable is being set by the user as a make(1) argument.
When setting USE_EXTERNAL_LIBDEFLATE=1 as a make(1) argument a system version will be used and otherwise it will use the vendored libdeflate.
|
@unknownbrackets When you have time I would really appreciate if you can review this PR. |
unknownbrackets
approved these changes
Jan 26, 2024
|
@unknownbrackets Thanks! Any chance you could tag a new patch release? It would be helpful to get the build fixes into distros and its a bit much to backport. |
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Jan 27, 2024
Upstream now supports an external libdeflate. Upstream-PR: unknownbrackets/maxcso#83 Upstream-Commit: unknownbrackets/maxcso@4949344 Signed-off-by: orbea <[email protected]>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Jan 27, 2024
Upstream now supports an external libdeflate. Upstream-PR: unknownbrackets/maxcso#83 Upstream-Commit: unknownbrackets/maxcso@4949344 Signed-off-by: orbea <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Feb 23, 2024
Upstream now supports an external libdeflate. Upstream-PR: unknownbrackets/maxcso#83 Upstream-Commit: unknownbrackets/maxcso@4949344 Signed-off-by: orbea <[email protected]> Closes: #35035 Signed-off-by: Viorel Munteanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
USE_EXTERNAL_LIBDEFLATE=1as amake(1)argument a system version will be used and otherwise it will use the vendored libdeflate.This was tested using
libdeflate-1.19that was recently added to Gentoo (gentoo/gentoo@bae8948).There are also a few trivial commits to improve the Makefile.