Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ColorProvider option is only called for the root level #150

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

pverscha
Copy link
Member

@pverscha pverscha commented Jan 9, 2024

The TreeView visualization supports a custom ColorProvider function that allows third-party users to configure the color's that are assigned to each node. Because of a bug, this function was only called for each node at the first two levels. This PR proposes a new fix, that is also backwards compatible, in which users need to specify until which depth in the tree this function needs to be computed.

I introduced a new option ColorProviderLevels that is now also taken into account during the visualization of the provided data and that allows to create treeviews like these:

image

@pverscha pverscha added the bug label Jan 9, 2024
@pverscha pverscha self-assigned this Jan 9, 2024
@pverscha pverscha merged commit 807a02c into develop Jan 9, 2024
1 of 2 checks passed
@pverscha pverscha deleted the fix/colorprovider-call-wrong branch January 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant