Ids are no longer required

unipept · Mar 15, 2021 · 2de4d0b · 2de4d0b
1 parent 1981c84
commit 2de4d0b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/src/visualizations/heatmap/Heatmap.ts b/src/visualizations/heatmap/Heatmap.ts
@@ -77,9 +77,6 @@ export default class Heatmap {
         this.settings = this.fillOptions(options);
 
         this.element = elementIdentifier;
-        if (!this.element.id) {
-            this.element.id = "U_HEATMAP_" + Math.floor(Math.random() * 2**16);
-        }
 
         const preprocessor = new Preprocessor();
         this.rows = preprocessor.preprocessFeatures(rowLabels);
@@ -952,7 +949,7 @@ export default class Heatmap {
     private initTooltip() {
         return d3.select("body")
             .append("div")
-            .attr("id", this.element.id + "-tooltip")
+            .attr("id", Math.floor(Math.random() * 2**16) + "-tooltip")
             .attr("class", "tip")
             .style("position", "absolute")
             .style("z-index", "10")

diff --git a/src/visualizations/sunburst/Sunburst.ts b/src/visualizations/sunburst/Sunburst.ts
@@ -45,15 +45,11 @@ export default class Sunburst {
     ) {
         this.settings = this.fillOptions(options);
 
-        if (!this.element.id) {
-            this.element.id = "U_SUNBURST_" + Math.floor(Math.random() * 2**16);
-        }
-
         const preprocessor = new SunburstPreprocessor();
         const processedData = preprocessor.preprocessData(data);
 
         if (this.settings.enableTooltips) {
-            this.tooltip = TooltipUtilities.initTooltip(this.element.id);
+            this.tooltip = TooltipUtilities.initTooltip(Math.floor(Math.random() * 2**16).toString());
         }
 
         this.currentMaxLevel = this.settings.levels;
@@ -82,7 +78,7 @@ export default class Sunburst {
         // @ts-ignore
         this.breadCrumbs = d3.select(this.element)
             .append("div")
-            .attr("id", this.element.id + "-breadcrumbs")
+            .attr("id", Math.floor(Math.random() * 2**16) + "-breadcrumbs")
             .attr("class", "sunburst-breadcrumbs")
             .append("ul");
 

diff --git a/src/visualizations/treemap/Treemap.ts b/src/visualizations/treemap/Treemap.ts
@@ -33,12 +33,8 @@ export default class Treemap {
     ) {
         this.settings = this.fillOptions(options);
 
-        if (!this.element.id) {
-            this.element.id = "U_TREEMAP_" + Math.floor(Math.random() * 2**16);
-        }
-
         if (this.settings.enableTooltips) {
-            this.tooltip = TooltipUtilities.initTooltip(this.element.id);
+            this.tooltip = TooltipUtilities.initTooltip(Math.floor(Math.random() * 2**16).toString());
         }
 
         this.initCss();

diff --git a/src/visualizations/treeview/Treeview.ts b/src/visualizations/treeview/Treeview.ts
@@ -38,12 +38,8 @@ export default class Treeview {
     ) {
         this.settings = this.fillOptions(options);
 
-        if (!this.element.id) {
-            this.element.id = "U_TREEVIEW_" + Math.floor(Math.random() * 2**16);
-        }
-
         if (this.settings.enableTooltips) {
-            this.tooltip = TooltipUtilities.initTooltip(this.element.id);
+            this.tooltip = TooltipUtilities.initTooltip(Math.floor(Math.random() * 2**16).toString());
         }
 
         const dataProcessor = new TreeviewPreprocessor();