Remove id's from tooltips

unipept · Apr 30, 2021 · 100f667 · 100f667
1 parent 241f94d
commit 100f667
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 8 deletions.
diff --git a/src/utilities/TooltipUtilities.ts b/src/utilities/TooltipUtilities.ts
@@ -1,10 +1,9 @@
 import * as d3 from "d3";
 
 export default class TooltipUtilities {
-    public static initTooltip(elementId: string): d3.Selection<HTMLDivElement, unknown, HTMLElement, any> {
+    public static initTooltip(): d3.Selection<HTMLDivElement, unknown, HTMLElement, any> {
         return d3.select("body")
             .append("div")
-            .attr("id", elementId + "-tooltip")
             .attr("class", "tip")
             .style("position", "absolute")
             .style("z-index", "10")

diff --git a/src/utilities/__tests__/TooltipUtilities.spec.ts b/src/utilities/__tests__/TooltipUtilities.spec.ts
@@ -2,9 +2,8 @@ import TooltipUtilities from "./../TooltipUtilities";
 
 describe("TooltipUtilities.initTooltip", () => {
     it("should produce a tooltip that satisfies the requirements", () => {
-        const tooltip = TooltipUtilities.initTooltip("unique-identifier");
+        const tooltip = TooltipUtilities.initTooltip();
 
-        expect(tooltip.attr("id")).toContain("unique-identifier");
         expect(tooltip.attr("class")).toEqual("tip");
     });
 });
diff --git a/src/visualizations/heatmap/Heatmap.ts b/src/visualizations/heatmap/Heatmap.ts
@@ -949,7 +949,6 @@ export default class Heatmap {
     private initTooltip() {
         return d3.select("body")
             .append("div")
-            .attr("id", Math.floor(Math.random() * 2**16) + "-tooltip")
             .attr("class", "tip")
             .style("position", "absolute")
             .style("z-index", "10")

diff --git a/src/visualizations/sunburst/Sunburst.ts b/src/visualizations/sunburst/Sunburst.ts
@@ -49,7 +49,7 @@ export default class Sunburst {
         const processedData = preprocessor.preprocessData(data);
 
         if (this.settings.enableTooltips) {
-            this.tooltip = TooltipUtilities.initTooltip(Math.floor(Math.random() * 2**16).toString());
+            this.tooltip = TooltipUtilities.initTooltip();
         }
 
         this.currentMaxLevel = this.settings.levels;

diff --git a/src/visualizations/treemap/Treemap.ts b/src/visualizations/treemap/Treemap.ts
@@ -34,7 +34,7 @@ export default class Treemap {
         this.settings = this.fillOptions(options);
 
         if (this.settings.enableTooltips) {
-            this.tooltip = TooltipUtilities.initTooltip(Math.floor(Math.random() * 2**16).toString());
+            this.tooltip = TooltipUtilities.initTooltip();
         }
 
         this.initCss();

diff --git a/src/visualizations/treeview/Treeview.ts b/src/visualizations/treeview/Treeview.ts
@@ -39,7 +39,7 @@ export default class Treeview {
         this.settings = this.fillOptions(options);
 
         if (this.settings.enableTooltips) {
-            this.tooltip = TooltipUtilities.initTooltip(Math.floor(Math.random() * 2**16).toString());
+            this.tooltip = TooltipUtilities.initTooltip();
         }
 
         const dataProcessor = new TreeviewPreprocessor();