Add sort_peptides back temporarily #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, yes, this makes sense. In innodb, tables/indexes are stored in a sorted order. Inserting in non-sorted order will cause rewrites. |
pverscha
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 6 weeks of trying to import the MariaDB database I discovered that the peptides not being sorted is the culprit.
This does not make any impact for Postgres, but apparently it makes a massive impact for MariaDB.
Hence, I've added the old
sort_peptidesstep back in. Added some TODO comments so we can find it again in the near future when we switch to PSQL.