Re-write WriteToChunk and TaxaByChunk in Rust #23
rust.yml
on: pull_request
Install dependencies
2m 16s
Annotations
4 errors
Check formatting
Process completed with exit code 1.
|
Linting:
scripts/helper_scripts/unipept-database-rs/src/bin/write-to-chunk.rs#L74
[clippy] reported by reviewdog 🐶
error: useless use of `format!`
--> src/bin/write-to-chunk.rs:74:64
|
74 | let file_handler = File::create(file_path).with_context(|| format!("Unable to create header output file"))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unable to create header output file".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
Raw Output:
src/bin/write-to-chunk.rs:74:64:e:error: useless use of `format!`
--> src/bin/write-to-chunk.rs:74:64
|
74 | let file_handler = File::create(file_path).with_context(|| format!("Unable to create header output file"))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unable to create header output file".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
__END__
|
Linting:
scripts/helper_scripts/unipept-database-rs/src/bin/taxa-by-chunk.rs#L51
[clippy] reported by reviewdog 🐶
error: single-character string constant used as pattern
--> src/bin/taxa-by-chunk.rs:51:46
|
51 | let range = replaced_name.split_once("-");
| ^^^ help: try using a `char` instead: `'-'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
Raw Output:
src/bin/taxa-by-chunk.rs:51:46:e:error: single-character string constant used as pattern
--> src/bin/taxa-by-chunk.rs:51:46
|
51 | let range = replaced_name.split_once("-");
| ^^^ help: try using a `char` instead: `'-'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
__END__
|
Linting
reviewdog exited with status code: 1
|