Port peptfilter to typescript #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
force-pushed
the
next-peptfilter
branch
from
85b3575 to
f5b879f
Compare
pverscha
reviewed
Jun 20, 2024
| @@ -0,0 +1,6 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| import { Peptfilter } from '../lib/commands/peptfilter.js'; | |||
There was a problem hiding this comment.
Why is this import from a "js" file? Shouldn't this be "ts"?
There was a problem hiding this comment.
You can make .js, .ts and nothing work with the right settings. I would have prefered using no extension, but couldn't get it to work in all conditions: the typescript compiler itself, running it after compilation, running it with yarn and running it through tests. This is the only way I managed to get it to work under all conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the peptfilter command in typescript.
I ran peptfilter on swissprot as a benchmark.
The original ruby code took 25 seconds, the reimplementation takes 4 seconds.