Fix: Specifying multiple names or IDs causing only last value to be selected #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pederhan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several commands that allow for multiple names or ids to be specified. A bug caused the
parse_name_or_id_argfunction to overwrite thefiltervalue with the last value in the list of usernames or ids whensearch=False. Now, we automatically assume we are searching when given multiple values, as one cannot filter by multiple names.It is unclear exactly which commands this affected, but in any case, this PR should now make any commands that use the
parse_name_or_id_argto behave consistently and in the way we expect.Furthermore, some bugs related to building params for certain commands in Zabbix >= 6.0 was discovered and fixed (see changelog).