Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17014 No code fallbacks for language/script paths #4290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jan 17, 2025

-Use the extra-paths mechanism instead of code-fallback; new ExtraPaths.java

-For each type (language/script), create the set of extra paths only once

-Change es-419 to es (419) in localeDisplayName.txt so TestLocaleDisplay passes

-Revise testExtraPaths, testGetPaths, so they pass

-Comments

CLDR-17014

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Use the extra-paths mechanism instead of code-fallback; new ExtraPaths.java

-For each type (language/script), create the set of extra paths only once

-Change es-419 to es (419) in localeDisplayName.txt so TestLocaleDisplay passes

-Revise testExtraPaths, testGetPaths, so they pass

-Comments
@btangmu btangmu self-assigned this Jan 17, 2025
@btangmu
Copy link
Member Author

btangmu commented Jan 17, 2025

This PR is very similar to #4254, but in addition to language paths it also applies to script paths, and the new class ExtraPaths is refactored to facilitate adding more types in addition to language/script

@btangmu btangmu requested review from macchiati and srl295 January 17, 2025 20:16
@btangmu
Copy link
Member Author

btangmu commented Jan 17, 2025

@macchiati please let me know when it's OK to deploy this to cldr-staging for testing

screenshot running locally:

http://localhost:8888/cldr-apps/v#/aa/Scripts/44d4d43894cfbd45

image

compare production https://st.unicode.org/cldr-apps/v#/root/Scripts/44d4d43894cfbd45

image

@macchiati
Copy link
Member

macchiati commented Jan 18, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants