Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-15830 Add explanatory comments in NameType.java #4252

Merged
merged 1 commit into from
Dec 23, 2024
Merged

CLDR-15830 Add explanatory comments in NameType.java #4252

merged 1 commit into from
Dec 23, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Dec 19, 2024

CLDR-15830

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@btangmu btangmu self-assigned this Dec 19, 2024
conradarcturus
conradarcturus approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@conradarcturus conradarcturus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D I love code comments

@btangmu btangmu merged commit 9bbbc77 into unicode-org:main Dec 23, 2024
13 checks passed
@btangmu btangmu deleted the t15830_d branch December 23, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradarcturus conradarcturus conradarcturus approved these changes

@srl295 srl295 srl295 approved these changes

@macchiati macchiati Awaiting requested review from macchiati

Assignees

@btangmu btangmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btangmu @srl295 @conradarcturus