CLDR-17612 cla: update text, record version #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the self-sign for corp cla
- also, form cleanup
- also, fix date serialization issue in UserSettings (Gson setting issue) for the signed date
|
fyi @annebright |
- move "please contact" text up
|
text update:
|
AEApple
approved these changes
Dec 11, 2024
srl295
commented
Dec 13, 2024
| @@ -92,7 +93,7 @@ public boolean persistent() { | |||
| } | |||
|
|
|||
| public void setJson(String name, Object o) { | |||
| final Gson gson = new Gson(); | |||
| final Gson gson = new GsonBuilder().setDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").create(); | |||
There was a problem hiding this comment.
this makes it work properly serializing dates.
btangmu
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17612
ALLOW_MANY_COMMITS=true
Screenshot