Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-18058 Release page nits #4160

Merged
merged 2 commits into from
Oct 25, 2024
Merged

CLDR-18058 Release page nits #4160

merged 2 commits into from
Oct 25, 2024

Conversation

stenshamn
Copy link
Contributor

CLDR-18058

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@github-actions GitHub Actions
Copy link

✨ deployed to https://513e3315.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Oct 24, 2024
pedberg-icu
pedberg-icu approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thanks!

@github-actions GitHub Actions
Copy link

✨ deployed to https://ee416e6d.cldr.pages.dev

AEApple
AEApple approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

although I may want to update the numbers under the number to bullets in a future PR for consistency.

@pedberg-icu
Copy link
Contributor

I am going to go ahead and merge this

@pedberg-icu pedberg-icu merged commit 2ca96f0 into main Oct 25, 2024
14 checks passed
@srl295 srl295 deleted the CLDR-18058-BRS46-release-page-updates branch October 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedberg-icu pedberg-icu pedberg-icu approved these changes

@AEApple AEApple AEApple approved these changes

@srl295 srl295 Awaiting requested review from srl295

@macchiati macchiati Awaiting requested review from macchiati

Assignees

@stenshamn stenshamn

Labels
Site Update Updates docs/site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stenshamn @pedberg-icu @AEApple