CLDR-16844 Preliminary refactoring for Dashboard #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-New module cldrDashContext.mjs, mostly code moved from cldrGui.mjs -Encapsulate some constant strings such as OPEN_DASH_BUTTON_CLASS -Rename cldrDash.mjs to cldrDashData.mjs for clarity -Rename TestCldrDash.mjs to TestCldrDashData.mjs -Remove unused parameter tr from cldrTable.getSingleRowUrl -Remove some debugging console.log calls from DashboardWidget.vue -Comments
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
reviewed
Jul 23, 2024
| import * as cldrNotify from "./cldrNotify.mjs"; | ||
| import * as cldrVue from "./cldrVue.mjs"; | ||
|
|
||
| import DashboardWidget from "../views/DashboardWidget.vue"; |
There was a problem hiding this comment.
this is a new structure for the esm dir..
srl295
reviewed
Jul 23, 2024
| @@ -14,17 +14,13 @@ import * as cldrStatus from "./cldrStatus.mjs"; | |||
| import * as cldrSurvey from "./cldrSurvey.mjs"; | |||
| import * as cldrVue from "./cldrVue.mjs"; | |||
|
|
|||
| import DashboardWidget from "../views/DashboardWidget.vue"; | |||
srl295
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-New module cldrDashContext.mjs, mostly code moved from cldrGui.mjs
-Encapsulate some constant strings such as OPEN_DASH_BUTTON_CLASS
-Rename cldrDash.mjs to cldrDashData.mjs for clarity
-Rename TestCldrDash.mjs to TestCldrDashData.mjs
-Remove unused parameter tr from cldrTable.getSingleRowUrl
-Remove some debugging console.log calls from DashboardWidget.vue
-Comments
CLDR-16844
ALLOW_MANY_COMMITS=true