Refactor jquery selectors #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is a first of many series of improvements to the ORS views and javascript.
The
remove-js-from-viewsbranch has been created starting from master, and all the tasks (including this one) regarding the javascript refactoring should be merged in there.In this PR I refactored the easiest of the javascript which was still in the views; it's mainly about selectors and events and I have moved those into new or already existing coffeescripts components.
I believe that at a certain stage we should also consider using a javascript framework (possibly React), because the other bits of javascript are quite complicated to refactor and need interaction with the backend as well.