-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added dark mode to site #30
Conversation
Thank you for opening the PR, @pateldivyesh1323! Could you please consider implementing the persistence of the user's chosen theme? We will also provide you with the color palette for the dark theme next Monday (October 9th), as soon as our Designer returns. |
We've prepared a Figma design with precise color details and improvements for our dark mode. You can access it here: https://www.figma.com/file/pasjtGKiZws9pkiVK9Gzp3/Playground?type=design&node-id=0-1&mode=design Here are the key changes:
You can interact with the Figma prototype here: https://www.figma.com/proto/pasjtGKiZws9pkiVK9Gzp3/Playground?type=design&node-id=29-836&scaling=min-zoom&page-id=0%3A1&starting-point-node-id=29%3A836&hide-ui=1 Could you please implement these changes? Thank you for your patience. |
@matheusfm I have made some commits and need a review on it. I am confused with
|
It's not necessary. For these two areas, just use themes
What excatly does it break? |
@pateldivyesh1323 |
@matheusfm ok, I will do that. |
@matheusfm Updated. |
Awesome, @pateldivyesh1323! |
Impressive, guys! @matheusfm @pateldivyesh1323 |
Description
Added Dark mode feature to the site
Linked Issues
Fixes : #25
Video
CEL.Playground.-.Google.Chrome.2023-10-03.00-23-21.mp4
How has this been tested?
Checklist