Fixed Usage of RegExp Objects #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-commented require.paths from syntax_highlighter, deprecated in node.js 0.6.8
…ated in node.0.6.8
| binary = binary.replace(/([\u0000-\u001F\u0080-\u009F])/g, function (x, char) { | ||
| if (/[^\r\n\t]/(char)) { | ||
| var num = char.charCodeAt(0).toString(16); | ||
| binary = binary.replace(/([\u0000-\u001F\u0080-\u009F])/g, function (x, chr) { |
There was a problem hiding this comment.
Changed variable name from char to chr, just to be on the sure side, since some sources say that Java keywords are reserved in JavaScript, although it seems to work in my local node.
|
Seems to fix issue #62 for me as well. |
|
Nice work Doc! |
|
Great! You can also fix the path issues by replacing require's with relative paths. I liked the old trickery with the require.paths array but it seems its no longer supported by node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegExp Objects, that is Regular Expressions created with /.../ were used wrongly throughout the code, as first remarked by boog.
They cannot be matched on a string just like: /.../(string), but need to be called upon with either test or exec, cf. here: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/RegExp.
I also commented out require.paths which is deprecated in node 0.6.8 and thus does not work.
You need to add the requisite paths to your env under NODE_PATH, like boog had also remarked in #68.
With these out of the way, and recompiling TermKit for 10.7 it actually worked for me.