[Exploration] Office Hours Querying Enhancements #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaygandecha
added
exploration
ajaygandecha
added
the
DONT MERGE
ajaygandecha
changed the title
ajaygandecha
changed the title
|
( @wzahrt // @atoneyd // @ItIsAndrewL), no todos or anything pressing, but pinging you all on this pull request to alert you of potential (needed) optimizations coming down the pipe to load office hours data for the TV signage, where applicable (specifically if any APIs are querying with joins between course sites, office hour events, and tickets). |
Merged
ajaygandecha
changed the title
ajaygandecha
removed
the
DONT MERGE
|
@KrisJordan, removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explores refactoring the permission check functions used in the common office hours CRUD backend service functions. The idea of these refactors is to load as little information as possible while churning over many courses, members, and sections. Some of these ideas are based off of SQLAlchemy documentation, examples, research, and some suggested optimizations from AI.
@KrisJordan and @jadekeegan, would like to hear your thoughts on this. @KrisJordan, I think to solve the problem noticed in larger courses like COMP 301, it might be helpful if you can gather any other insights on
502errors occurring on the backend side, as well as the number of observations in the tables we are dealing with (particularlyticket,office-hours(formerly office hour events), andsection_member).