Fix bug in front-end with desk drop-in prereservations. (#344)

backend/services/coworking/policy.py

@@ -29,7 +29,7 @@ def __init__(self): ...
 
     def walkin_window(self, _subject: User) -> timedelta:
         """How far into the future can walkins be reserved?"""
-        return timedelta(minutes=30)
+        return timedelta(minutes=10)
 
     def walkin_initial_duration(self, _subject: User) -> timedelta:
         """When making a walkin, this sets how long the initial reservation is for."""

frontend/src/app/coworking/room-reservation/room-reservation.service.ts

@@ -31,8 +31,11 @@ export class RoomReservationService extends ReservationService {
     r: Reservation
   ) => {
     let now = new Date();
+    let soon = new Date(
+      Date.now() + 10 /* minutes */ * 60 /* seconds */ * 1000 /* milliseconds */
+    );
     const activeStates = ['CONFIRMED', 'CHECKED_IN'];
-    return r.start <= now && r.end > now && activeStates.includes(r.state);
+    return r.start <= soon && r.end > now && activeStates.includes(r.state);
   };
 
   constructor(http: HttpClient) {

frontend/src/app/coworking/widgets/dropin-availability-card/dropin-availability-card.widget.ts

@@ -33,18 +33,23 @@ class SeatCategory {
            to server and client sharing the same system clock, but experienced in
            prod on day 0 with many laptops having slightly drifted system clocks. */
     const now = new Date(Date.now() + epsilon);
+    const preReservableAt = new Date(
+      Date.now() + 10 /*minutes*/ * 60 /*seconds*/ * 1000 /*milliseconds*/
+    ); // Currently set by backend/services/coworking/policy.py
     if (seat.availability[0].start <= now) {
       this.seats_available_now.push(seat);
       if (this.seats_available_now.length === 1) {
         this.reservable_now = true;
         this.next_available = seat;
       }
-    } else {
+    } else if (seat.availability[0].start <= preReservableAt) {
       this.seats_available_soon.push(seat);
       if (!this.reservable_now && this.seats_available_soon.length === 1) {
         this.reservable_soon = true;
         this.next_available = seat;
       }
+    } else {
+      // Ignore seats that are not pre-reservable
     }
   }