Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node that fakes object detection information in sim #625

Closed
wants to merge 3 commits into from

Conversation

alisonryckman
Copy link
Contributor

Summary

Closes #555 , #603

What features did you add, bugs did you fix, etc?
Adds node which publishes object location to sim to fake object detection information. Also adds mallet model to sim in a new sim world file.

Did you add documentation to the wiki?

No

How was this code tested?

Tested in sim by attempting to publish the object when it does/doesn't exist in the world

Did you test this in sim?

Yes

Did you test this on the rover?

No

Did you add unit tests?

No

Copy link
Contributor

@Emerson-Ramey Emerson-Ramey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

Copy link
Collaborator

@ankithu ankithu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add the part we talked about with checking the distance to the rover and only publishing in that case.

@qhdwight
Copy link
Collaborator

Used this as a guide to add it to the new sim, thanks.

@qhdwight qhdwight closed this Jan 23, 2024
@qhdwight qhdwight deleted the obj-in-sim branch March 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dummy node in sim that fakes object detection information Put mallet in simulator
4 participants