Allow Symfony 6 #33
Merged
Allow Symfony 6 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
sf6
branch
2 times, most recently
from
da05a0e to
6b1bde9
Compare
|
phpspec/prophecy#527 is the remaining blocker. My suggestion would be another job outside the matrix that runs just phpspec on 7.4. WDYT? |
|
If you don't have time to wait for phpspec/prophecy#527 to be resolved, we can do that and create issue to update once phpspec/prophecy#527 is fixed. |
|
Is it important to run phpspec on every matrix environment? I'm not familiar with this library. We sort of have 2 options:
|
|
We can do 2. It's desirable to run it on every matrix if possible. Thanks. |
|
Ok, this is ready. I disabled phpspec on Symfony 6 only. |
|
@umpirsky, could I trouble you for a new tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.