Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复一个三方依赖exports导出__esModule=true引起的导入问题 #12420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SANmq
Copy link
Contributor

@SANmq SANmq commented May 27, 2024

webpack本来可以正常处理模块,因为依赖导出带有__esModule.webpack导入的时候当成es模块处理去取default,结果模块里没有default,已经被esbuild导出的时候处理了,结果导致webpack 默认导入失败,
起因是旧项目升级打包工具webpack5.91.0。顺便用umijs mfsu优化开发体验,结果遇到一些问题。在启用mfsu时 项目代码在导入import locale from 'element-ui/lib/locale' 版本是2.15.14 的时候提示locale不存在.后来发现其代码中有exports.__esModule = true;去掉之后就正常了。所以希望这里兼容一下,就不要将模块里的__esModule这个字段给合并了

Summary by CodeRabbit

  • 修复
    • 修改了 ES 互操作辅助函数,以避免在定义属性时包含 __esModule 键。

webpack本来可以正常处理模块,因为依赖导出带有__esModule.webpack导入的时候当成es模块处理去取default,结果模块里没有default,已经被esbuild导出的时候处理了,结果导致webpack 默认导入失败,
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 2:20pm

Copy link

coderabbitai bot commented May 27, 2024

Walkthrough

这次修改主要涉及在 getESBuildEntry.ts 中修改了 ES 互操作助手函数,以便在定义属性时基于键值不是 __esModule 的条件进行操作。

Changes

文件路径 修改摘要
packages/mfsu/src/depBuilder/getESBuildEntry.ts 修改了 ES_INTEROP_HELPER 函数,使其在键值不是 __esModule 时才定义属性

🐇
代码变更如春风,
细雨润物细无声。
条件判断添智慧,
模块互通更分明。
兔子欢喜舞翩翩,
程序世界更光明。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f6abd77 and 7cc8542.
Files selected for processing (1)
  • packages/mfsu/src/depBuilder/getESBuildEntry.ts (1 hunks)
Additional Context Used
Biome (2)
packages/mfsu/src/depBuilder/getESBuildEntry.ts (2)

5-5: Do not use template literals if interpolation and special-character handling are not needed.


1-2: All these imports are only used as types.

Additional comments not posted (1)
packages/mfsu/src/depBuilder/getESBuildEntry.ts (1)

12-12: 同样地,通过添加条件检查来避免直接分配 __esModule 属性,这是一个必要的改进,以确保不会错误地覆盖 __esModule 属性。

@fz6m
Copy link
Contributor

fz6m commented May 27, 2024

应该不是 __esModule 的问题吧,我用一个新的项目,安装 element ui ,之后导入 import locale from 'element-ui/lib/locale' ,加载是正常的。

是历史缓存影响的吗,试试删了 node_modules/.cache 再试?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants