-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复一个三方依赖exports导出__esModule=true引起的导入问题 #12420
base: master
Are you sure you want to change the base?
Conversation
webpack本来可以正常处理模块,因为依赖导出带有__esModule.webpack导入的时候当成es模块处理去取default,结果模块里没有default,已经被esbuild导出的时候处理了,结果导致webpack 默认导入失败,
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Walkthrough这次修改主要涉及在 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/mfsu/src/depBuilder/getESBuildEntry.ts (1 hunks)
Additional Context Used
Biome (2)
packages/mfsu/src/depBuilder/getESBuildEntry.ts (2)
5-5: Do not use template literals if interpolation and special-character handling are not needed.
1-2: All these imports are only used as types.
Additional comments not posted (1)
packages/mfsu/src/depBuilder/getESBuildEntry.ts (1)
12-12
: 同样地,通过添加条件检查来避免直接分配__esModule
属性,这是一个必要的改进,以确保不会错误地覆盖__esModule
属性。
应该不是 __esModule 的问题吧,我用一个新的项目,安装 element ui ,之后导入 是历史缓存影响的吗,试试删了 |
webpack本来可以正常处理模块,因为依赖导出带有__esModule.webpack导入的时候当成es模块处理去取default,结果模块里没有default,已经被esbuild导出的时候处理了,结果导致webpack 默认导入失败,
起因是旧项目升级打包工具webpack5.91.0。顺便用umijs mfsu优化开发体验,结果遇到一些问题。在启用mfsu时 项目代码在导入import locale from 'element-ui/lib/locale' 版本是2.15.14 的时候提示locale不存在.后来发现其代码中有exports.__esModule = true;去掉之后就正常了。所以希望这里兼容一下,就不要将模块里的__esModule这个字段给合并了
Summary by CodeRabbit
__esModule
键。