Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP2000-1632 Auto-end-date footnote associations #1387

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

TP2000-1632 Auto-end-date footnote associations #1387

wants to merge 10 commits into from

Conversation

mattjamc
Copy link
Collaborator

@mattjamc mattjamc commented Jan 16, 2025 •
edited
Loading

TP2000-1632 Auto-end-date footnote associations

Why

When a commodity is end-dated by the EU, tariff managers need to also end date or delete any footnote associations on that commodity code.

What

This PR:

  • extends the auto end-dating of measures functionality to also end-date footnote associations by changing it to a generic function which works for any tracked model
  • updates the layout of the page to a tabbed view so the user can see both measures and footnote associations to be ended
  • adds a new test for footnote associations and refactors and parameterizes 2 existing tests so they account for associations as well as measures
Screen.Recording.2025-01-17.at.17.35.07.mov

@mattjamc mattjamc marked this pull request as ready for review January 20, 2025 12:16
@mattjamc mattjamc requested a review from a team as a code owner January 20, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattjamc