Code cleanup grtlv 417 update learn to export footer and remove old footers #3650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding the design system header to core/base.html as some sections (learn) don't use the domestic template. Removing unused footer styles and templates. Also added a very quick fix as the header menu javascript isn't working on prod, so added a block.super to fix.
Note - don't merge until I check with david that the core/base.html footer cache will still work as expected
Why
Make great more maintainable with cleaner styles
Tick or delete as appropriate:
Workflow
Reviewing help
Housekeeping
Security
Performance
Merging