Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup grtlv 417 update learn to export footer and remove old footers #3650

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

FoxJamie16
Copy link
Contributor

What

Adding the design system header to core/base.html as some sections (learn) don't use the domestic template. Removing unused footer styles and templates. Also added a very quick fix as the header menu javascript isn't working on prod, so added a block.super to fix.

Note - don't merge until I check with david that the core/base.html footer cache will still work as expected

Why

Make great more maintainable with cleaner styles

Tick or delete as appropriate:

Workflow

Reviewing help

Housekeeping

  • I have checked that my PR is using the latest package versions of: great-components, directory-constants, directory-healthcheck, directory-validators, directory-components, directory-api-client, directory-ch-client, django-staff-sso-client, directory-forms-api-client, directory-sso-api-client, sigauth

Security

  • Frontend assets have been re-compiled
  • Checked for potential security vulnerabilities
  • Ensured any sensitive data is handled appropriately

Performance

  • Evaluated the performance impact of the changes
  • Ensured that changes do not negatively affect application scalability.

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

@FoxJamie16 FoxJamie16 requested a review from a team as a code owner November 15, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants